Re: [PATCH v4 01/29] network: ensure floor sum is reset to zero when starting networks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/17/19 1:19 PM, Daniel P. Berrangé wrote:
In extreme cases libvirt can get mixed up about what VMs are running and
attached to a network leading to the cached floor sum value being
outdated. When this happens the only option is to destroy the network
and then restart libvirtd. If we set floor sum back to zero when
starting the network, we avoid the need for a libvirtd restart at least.

Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Reviewed-by: Laine Stump <laine@xxxxxxxxx>


---
  src/network/bridge_driver.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 6e15e43ca6..3008846074 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -2826,6 +2826,8 @@ networkStartNetwork(virNetworkDriverStatePtr driver,
          goto cleanup;
      }
+ virNetworkObjSetFloorSum(obj, 0);
+
      /* finally we can call the 'started' hook script if any */
      if (networkRunHook(obj, NULL, NULL,
                         VIR_HOOK_NETWORK_OP_STARTED,


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux