On Tue, 2019-04-16 at 12:51 -0400, Cole Robinson wrote:
> On 4/16/19 4:58 AM, Andrea Bolognani wrote:
> > On Mon, 2019-04-15 at 19:09 -0400, Cole Robinson wrote:
> > [...]
> > > + DO_TEST_CAPS_LATEST("virtio-transitional");
> > > + DO_TEST_CAPS_LATEST("virtio-non-transitional");
> >
> > We should also add
> >
> > DO_TEST_CAPS_VER("virtio-transitional", "3.1.0");
> > DO_TEST_CAPS_VER("virtio-non-transitional", "3.1.0");
> >
> > same as xml2argv. You can do that in a separate patch, though.
>
> Hmm I'm not sure if those bits will actually test any different code
> paths for xml2xml? I'd check coverage output but lcov is broken with
> gcc9 on f30
You're right, the only difference between the output files would be
the machine type. Never mind, then :)
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
