On Tue, Apr 16, 2019 at 12:59:34PM +0200, Ján Tomko wrote:
On Mon, Apr 15, 2019 at 04:59:30PM +0200, Ján Tomko wrote:On Mon, Apr 15, 2019 at 04:23:18PM +0200, Martin Kletzander wrote:I'll fix other things you mentioned and send a v3 if you want, just let me know.Depending on your opinion on the refactor: https://www.redhat.com/archives/libvir-list/2019-April/msg00996.htmlGiven Andrea's comments on that series I withdraw my virXMLFormatElement suggestion.
Based on the fact virDomainSchedulerParse() callers utilize the return value (which would not be used in the new one) nicely, I'll leave that function as is in this series so that the refactor discussion takes place in a separate thread (if anyone cares enough to do that). I think this way it actually is better as one function serves one purpose and not two slightly different ones based on variable parameter. Thanks.
Jano
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
