Re: [PATCH 2/2] util: Fix NAME section for virkey{code, name}-*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 15, 2019 at 03:21:01PM +0200, Andrea Bolognani wrote:
Spotted by Lintian (manpage-has-bad-whatis-entry tag).

Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
---
src/util/Makefile.inc.am | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)


Makes sense, the two rules above could also have a nicer name like this one, but
that's not needed (and neither what this patch is aiming to do).

Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>

diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am
index f44d3b3b2a..c757f5a6ae 100644
--- a/src/util/Makefile.inc.am
+++ b/src/util/Makefile.inc.am
@@ -321,7 +321,9 @@ util/virkeycode-%.pod: $(srcdir)/keycodemapdb/data/keymaps.csv \
					      -e 's,\.pod,,'` && \
		$(MKDIR_P) util/ && \
		$(PYTHON) $(srcdir)/keycodemapdb/tools/keymap-gen \
-		--lang pod --varname "Key code values for $$NAME" code-docs \
+		--lang pod \
+		--varname "virkeycode-$$NAME - Key code values for $$NAME" \
+		code-docs \
		$(srcdir)/keycodemapdb/data/keymaps.csv $$NAME > \
			$@-tmp && mv $@-tmp $@ || rm $@-tmp

@@ -331,7 +333,9 @@ util/virkeyname-%.pod: $(srcdir)/keycodemapdb/data/keymaps.csv \
					      -e 's,\.pod,,'` && \
		$(MKDIR_P) util/ && \
		$(PYTHON) $(srcdir)/keycodemapdb/tools/keymap-gen \
-		--lang pod --varname "Key name values for $$NAME" name-docs \
+		--lang pod \
+		--varname "virkeyname-$$NAME - Key name values for $$NAME" \
+		name-docs \
		$(srcdir)/keycodemapdb/data/keymaps.csv $$NAME > \
			$@-tmp && mv $@-tmp $@ || rm $@-tmp

--
2.20.1

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux