Re: [PATCH for v5.3.0 17/17] Revert "qemu: Temporary disable owner remembering"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/28/19 11:04 AM, Michal Privoznik wrote:
> This reverts commit fc3990c7e64be1da1631952d3ec384ebef50e125.
> 
> Now that all the reported bugs are fixed let's turn the feature
> back on.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  docs/news.xml                      | 21 +++++++++++++++++++++
>  src/qemu/libvirtd_qemu.aug         |  1 +
>  src/qemu/qemu.conf                 |  5 +++++
>  src/qemu/qemu_conf.c               |  4 ++++
>  src/qemu/test_libvirtd_qemu.aug.in |  1 +
>  5 files changed, 32 insertions(+)
> 


Code wise for 11-17:

Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx>

Patch 12 should drop the redundant error reporting but that doesn't need
re-review. I didn't dig deeply into call chain of the qemu mirror/rebase
bits but the code looks sane.

Patch 10 comments point out additional issues that I think should block
committing this patch though. But if you think those will be easy fixes
and want to push this first, no objections from me.

Thanks,
Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux