On Fri, Apr 12, 2019 at 11:25:36AM +0200, Michal Privoznik wrote: > Firstly, virCommandRun() does report an error on failure (which > in most cases is more accurate than what we overwrite it with). > Secondly, usually errno is not set (or gets overwritten in the > cleanup code) which makes virReportSystemError() report useless > error messages. Drop all virReportSystemError() calls in cases > like this (I've found three occurrences). > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > > I was under impression that I've sent this one earlier. Well, maybe I > did not. > > src/storage/storage_backend_fs.c | 7 +------ > src/util/virdnsmasq.c | 10 ++-------- > 2 files changed, 3 insertions(+), 14 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
