Re: [PATCH 3/3] qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 12, 2019 at 10:46:41AM +0200, Michal Privoznik wrote:
The latter is deprecated and will be removed soon. The advised
replacement is '-overcommit mem-lock=on|off'.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
src/qemu/qemu_command.c                               | 11 ++++++++---
.../channel-unix-guestfwd.x86_64-latest.args          |  2 +-
.../console-virtio-unix.x86_64-latest.args            |  2 +-
.../controller-virtio-scsi.x86_64-latest.args         |  2 +-
tests/qemuxml2argvdata/disk-aio.x86_64-latest.args    |  2 +-

[...]

.../x86_64-q35-graphics.x86_64-latest.args            |  2 +-
.../x86_64-q35-headless.x86_64-latest.args            |  2 +-
tests/qemuxml2argvtest.c                              |  4 ++--
81 files changed, 89 insertions(+), 84 deletions(-)

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 8b517d83aa..5dbb0fc974 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -2399,8 +2399,8 @@ mymain(void)
            QEMU_CAPS_DEVICE_PCIE_ROOT_PORT,
            QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY);

-    DO_TEST("mlock-on", NONE);
-    DO_TEST("mlock-off", NONE);
+    DO_TEST("mlock-on", QEMU_CAPS_OVERCOMMIT);
+    DO_TEST("mlock-off", QEMU_CAPS_OVERCOMMIT);
    DO_TEST("mlock-unsupported", NONE);

    DO_TEST_PARSE_ERROR("pci-bridge-negative-index-invalid", NONE);

With these switched to DO_TEST_CAPS:
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux