On Wed, Apr 10, 2019 at 12:52:12PM +0200, Andrea Bolognani wrote: > On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote: > [...] > > It is also possible to do cross compiled builds via the Debian containers > > > > make ci-build@debian-9-cross-s390x > > You're not advertising cross-compilation images until commit 6/7, > so either drop this from the commit message or squash that commit > into this one. I see no reason not to do the latter. Yeah we can squash it in now. > [...] > > +# Docker defaults to pulling the ':latest' tag but > > +# if the Docker repo above uses different conventions > > +# this can override it > > +CI_IMAGE_TAG = :master > > This should probably contain only "master", since that's the tag > itself and ":" is just a separator. We can change it later. FWIW, I included the ":" because it makes it easier with using images without a tag. Unfortunately doesn't doesn't treat "foo:" as being the same as "foo" - it raises an error in the former case :-( We could do some munging to conditionally add the ":" I guess Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
