On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
[...]
> @@ -40,8 +39,7 @@ testXML2XMLActive(const void *opaque)
> const struct testInfo *info = opaque;
>
> return testCompareDomXML2XMLFiles(driver.caps, driver.xmlopt,
> - info->infile, info->outfile, true,
> - 0,
> + info->infile, info->outfile, true, 0,
> TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS);
Unrelated formatting change. Squash this hunk into the previous
commit.
[...]
> @@ -134,40 +130,26 @@ testInfoSetPaths(struct testInfo *info,
> const char *name,
> int when)
> {
> + VIR_FREE(info->infile);
> + VIR_FREE(info->outfile);
It's a tad wasteful to free() info->infile just to generate an
identical string immediately afterwards, but in the grand scheme of
things I guess it's barely even a rounding error :)
With the comment above addressed,
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
