On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote:
[...]
> + @echo "Available cross-compiler container images:"
> + @echo
> + @echo " debian-[9,sid]-cross-aarch64"
All these should look either like
debian-{9,sid}-cross-...
(shell style, my personal preference) or
debian-(9|sid)-cross-...
(regex style): the style you've chosen here is not really something
I've seen around, better to stick with something more common.
With that addressed, and the patch squashed into 1/7,
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
