On Tue, Apr 09, 2019 at 12:16:22PM +0200, Ján Tomko wrote: > On Mon, Apr 08, 2019 at 01:43:17AM +0200, Ilias Stamatis wrote: > > Implement testDomainGetTime by returning the current time. > > > > Signed-off-by: Ilias Stamatis <stamatis.iliass@xxxxxxxxx> > > --- > > I initially implemented this using clock_gettime, but Pavel suggested > > that this might not be a good idea since it isn't a cross-platform > > function. So I used virTimeMillisNow instead and set the nanoseconds > > part to 0 which can be ok for the test driver. > > > > Do you have a consumer for this? There is probably no consumer for now. However the ultimate goal is to implement all APIs in the test driver in order to make the test driver implementation mandatory for every new API. > IIUC these APIs are used for testing by higher layers like virt-manager > or libvirt-dbus and having it return a different value every time does > not seem that useful. For example for nodeCPUstats we return hardcoded > values. I'm OK with hard-coding some specific value, my guess is that no management application will check the specific value but we can give them that possibility. Pavel
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
