On Thu, Apr 4, 2019 at 5:16 AM Cole Robinson <crobinso@xxxxxxxxxx> wrote:
*native in the subject
On 3/28/19 1:57 AM, Han Han wrote:
> Signed-off-by: Han Han <hhan@xxxxxxxxxx>
> ---
> src/vmware/vmware_conf.c | 2 +-
> src/vmware/vmware_driver.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c
> index 0c1b1f9550..76645a2e0d 100644
> --- a/src/vmware/vmware_conf.c
> +++ b/src/vmware/vmware_conf.c
> @@ -285,7 +285,7 @@ vmwareExtractVersion(struct vmware_driver *driver)
> break;
>
> case VMWARE_DRIVER_FUSION:
> - if (virAsprintf(&bin, "%s/%s", vmwarePath, "vmware-vmx") < 0)
> + if (virAsprintf(&bin, "%s/%s", vmwarePath, VMX_CONFIG_FORMAT_ARGV) < 0)
> goto cleanup;
> break;
>
This usage is building a binary path like /usr/bin/vmware-vmx, so
despite the strings being the same it's not the same type of usage. It
shouldn't be replaced IMO
Otherwise this series change makes sense, it's the same pattern used in
other drivers. I suggest squashing it down to one patch though and send a v2
Thanks for review. v2 link: https://www.redhat.com/archives/libvir-list/2019-April/msg00609.html
Thanks,
Cole
--
Best regards,
-----------------------------------
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
