Re: [PATCH 0/5] examples: enforce compiler warning flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 02, 2019 at 11:02:06AM +0100, Daniel P. Berrangé wrote:
The example programs emitted a number of warnings even without having
the WARN_CFLAGS set. Once they were set a bunch more flaws came to
light. Fix them all and enforce warnings so that the example programs
are higher quality code.

Daniel P. Berrangé (5):
 examples: fix 64-bit integer formatting on Windows
 examples: avoid goto jump over initialization of variable
 domtop: remove unused domain name parameter
 dominfo: make example more useful
 examples: enable all compiler warnings

examples/Makefile.am               |  3 ++-
examples/admin/client_info.c       |  7 ++++---
examples/admin/client_limits.c     |  2 +-
examples/admin/list_clients.c      |  3 ++-
examples/admin/threadpool_params.c |  2 +-
examples/dominfo/info1.c           | 25 ++++++++++++++-----------
examples/domtop/domtop.c           | 13 ++++++++-----
7 files changed, 32 insertions(+), 23 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux