On Thu, Apr 04, 2019 at 04:46:25PM +0200, Andrea Bolognani wrote: > On Thu, 2019-04-04 at 15:29 +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 04, 2019 at 10:25:52AM +0200, Andrea Bolognani wrote: > > > I would, however, suggest a slightly different implementation than > > > what you have here, where using the search bar would still send you > > > to https://libvirt.org/search.php?query=X, and that page would > > > contain three links: > > > > > > * "Search libvirt.org" > > > https://google.com/search?q=site:libvirt.org+X > > > > > > * "Search the libvirt wiki" > > > https://wiki.libvirt.org/index.php?search=X > > > > > > * "Search the libvir-list mailing list archives" > > > https://google.com/search?q=site:redhat.com/archives/libvir-list+X > > > > > > The advantages of this approach are that existing links pointing to > > > search.php will keep working, people will be able to search the > > > mailing list archives as well (this is a feature the current search > > > implementation is supposed to have) and search the wiki without > > > having to go through an extra hoop, and finally that extending the > > > search interface to include more sources would become as simple as > > > adding another generated link to the page. > > > > > > What do you think? > > > > Sounds reasonable, though I don't think it should be a search.php page. > > It can be done with a plain search.html page and small amount of > > javascript. > > > > Avoiding php has the benefit that it works for locally installed docs > > from the RPM. > > I'm not a big fan of requiring JavaScript for websites, but on the > other hand it looks like the search function is the only bit of PHP > code we have in the repository so I'm okay with the idea of dropping > it. > > That said, while I'd be perfectly comfortable implementing the idea > above in PHP, I wouldn't quite know where to start for a JavaScript > version. Dan, would you be willing to write that code yourself? Yes, I will have a go. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
