On Fri, Mar 22, 2019 at 03:03:06PM -0400, Laine Stump wrote: > On 3/19/19 8:46 AM, Daniel P. Berrangé wrote: > > When (un)plugging an interface into a network, the 'plugged' > > and 'unplugged' operations are invoked in the hook script. > > > > The data provided to the script contains the network XML, the > > domain XML and the domain interface XML. When we strictly split the > > drivers up this will no longer be possible and thus breakage is > > unavoidable. > > > anyway, the usefulness of these particular hooks is a bit tenuous, since > they happen prior to any tap/macvtap device being created. I do remember > somebody using it for *something* though. > > > > The hook scripts are not considered to be covered by the > > API guarantee so this is OK. > > > Tricky! > > > I don't suppose there's any way that the users could be warned about this > other than release notes? (I can't think of any, since it would require > parsing and understanding the hook script). Aside from release notes, best I could do was to change the event name to avoid accidentally processing bogus data. > > > Reviewed-by: Laine Stump <laine@xxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
