On Thu, Apr 04, 2019 at 12:18:39PM +0200, Andrea Bolognani wrote: > On Wed, 2019-04-03 at 18:11 +0100, Daniel P. Berrangé wrote: > [...] > > %if %{with_python2} > > +%if 0%{?fedora} >= 29 || 0%{?rhel} >= 8 > > +%py2_build > > +%else > > So based on this it looks like the %py*_build macros were only > introduced in Fedora 29... > > > %if %{with_python2} > > +%if 0%{?fedora} || 0%{?rhel} >= 8 > > +%py2_install > > +%else > > ... but based on this it seems like the %py*_install macros were > already present in Fedora 28? Yeah, it in fact dates back to F27. I just forgot to chop the F29 conditional out fully. > Looking at my Fedora 28 guest, more specifically in > > /usr/lib/rpm/macros.d/macros.python* > > I see the %py*_build macros, so I guess the latter version is the > correct one. > > Once you've removed the bogus '>= 29's, > > Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list