On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote: > Stream/fd callbacks accessing console object are called from the > event loop thread and the console object is also accessed from > the main thread so we are better add locking to handlers. > > Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx> > --- > tools/virsh-console.c | 35 +++++++++++++++++++++++++---------- > 1 file changed, 25 insertions(+), 10 deletions(-) > The qemuAgentIO and qemuMonitorIO callbacks also add have matching Ref/Unref calls along side the lock calls, but after scratching my head over it for a while I don't think it's necessary here: even if virConsoleShutdown is called from one of the callbacks, the main thread will still hold a reference until the callback releases the object lock Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
