Re: [PATCHv2 12/14] virjsondata: json_reformat input data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 02, 2019 at 17:41:51 +0200, Ján Tomko wrote:
> Remove trailing slashes and run json_reformat.
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  tests/virjsondata/parse-Harder-in.json      |  17 +-
>  tests/virjsondata/parse-NotSoSimple-in.json |  18 ++-
>  tests/virjsondata/parse-Simple-in.json      |   7 +-
>  tests/virjsondata/parse-VeryHard-in.json    | 167 +++++++++++++++++---
>  4 files changed, 177 insertions(+), 32 deletions(-)

I don't think we should do this for the input files and even for some
output files. The non-prettified input/output is used in QMP monitor
interactions and I think we should keep at least some in the "native"
format.

This is to complement most other test files like the caps replies where
we use the prettified output so that the files can be updated
reasonably. This static data does not have to change.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux