Re: [PATCH] virsh: cmdConsole: make --domain optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/1/19 2:04 PM, Ján Tomko wrote:
> In the absence of a domain parameter, console the user instead.
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  tools/virsh-domain.c | 25 ++++++++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)

Missing doc updates to virsh.pod. How is a user going to know they can
be consoled?


> +static const char *
> +constellation_phrases[] = {

s/constellation/consolation/ ?

> +    "Everything is going to be all right.",
> +    "Things are going to work out in the end.",
> +    "Imagine pleasant nonsense", /* https://www.instagram.com/p/BuRfmkrBigI/ */
> +    "Ursa Major",

except that you did mix in a constellation phrase.  Hmm.  Now I'm going
to have to run this command to resolve the confusion that has arisen in
my mind...

> +    "There, there.",
> +};
> +


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux