Re: [PATCH] virerror: Make error reporting prettier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/1/19 6:11 AM, Andrea Bolognani wrote:
On Mon, 2019-04-01 at 10:10 +0200, Michal Privoznik wrote:
So far, if something goes wrong we print an error message, e.g.
like this:

   virsh # start fedora
   error: Failed to start domain fedora
   error: internal error: process exited while connecting to monitor: 2019-04-01T08:08:49.753850Z qemu-system-x86_64: -object memory-backend-memfd,id=ram-node0,hugetlb=yes,hugetlbsize=0,size=8589934592,host-nodes=0,policy=bind: Property 'memory-backend-memfd.hugetlbsize' doesn't take value '0'

This is very boring and usually too low level for users to know
what is going on or how to fix the problem. Let's reimplement our
error reporting then. After this patch the previous error turns
into (my favourite):

   virsh # start fedora
   error: Failed to start domain fedora
   error: operation failed: the printer thinks its a router.
*it's

There are at least two more occurrences of the same mistake in

   http://pages.cs.wisc.edu/~ballard/bofh/excuses

Based on that, I have to assume the list has not been properly
vetted and might contain several other spelling/grammar issues.

NACK until the list of excuses has been proven to only contain
grammatically valid and correctly spelled English sentences.


Assuming a lack of commit access to that list, maybe a post-processor function in libvirt to correct the mistakes would be sufficient?

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux