On Mon, Apr 01, 2019 at 10:15:51AM +0200, Andrea Bolognani wrote: > On Wed, 2019-03-27 at 17:10 +0000, Daniel P. Berrangé wrote: > [...] > > @@ -48,23 +48,15 @@ matrix: > > os: osx > > env: > > - PATH="/usr/local/opt/gettext/bin:/usr/local/opt/ccache/libexec:/usr/local/opt/rpcgen/bin:$PATH" > > + - VIR_TEST_DEBUG=1 > > Since we're not running 'make check' on macOS, setting > VIR_TEST_DEBUG in its environment is not particularly useful :) Opps, should have been removed entirely in the patch that switches to use Makefile.ci for linux/mingw builds > On the other hand, this made me realize that our new Makefile.ci > does not set this environment variable itself, nor does it pass it > to the container if it's already present. I think we can just set > it unconditionally in Makefile.ci. Agreed. We can hardcode it safely even if not running the 'check' make target. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
