Re: [PATCH v3 4/6] travis: use declarative syntax for homebrew packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2019-03-27 at 17:10 +0000, Daniel P. Berrangé wrote:
> Instead of running custom commands use the new declarative syntax for
> listing extra homebrew packages.

s/homebrew/Homebrew/g in the commit message.

[...]
> +addons:
> +  homebrew:
> +    packages:
> +      - ccache
> +      - rpcgen
> +      - xz
> +      - yajl

According to the documentation[1], this is not equivalent to the
code you're replacing since it will not run 'brew update' before
installing packages. Updating the system before building sounds
like a good idea to me, but I could be convinced otherwise :)

Another thing I think is worth mentioning is that several times in
the past we had to work around Homebrew issues, which is easy to do
when you're calling it from the shell but not so when you use the
declarative syntax. Switching back and forth is simple enough,
though, so we can just do that if the need ever arises again.


[1] https://docs.travis-ci.com/user/installing-dependencies/#installing-packages-on-macos

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux