Eric Blake <eblake@xxxxxxxxxx> [2019-03-28, 09:05AM -0500]: > Even though Coverity can prove that 'last' is always set if the prior > loop executed, gcc 8.0.1 cannot: > > CC conf/libvirt_conf_la-virdomainmomentobjlist.lo > ../../src/conf/virdomainmomentobjlist.c: In function 'virDomainMomentMoveChildren': > ../../src/conf/virdomainmomentobjlist.c:178:19: error: 'last' may be used uninitialized in this function [-Werror=maybe-uninitialized] > last->sibling = to->first_child; > ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ > > Rewrite the loop to a form that should be easier for static analysis > to work with. > > Fixes: ced0898f86bf > Reported-by: Bjoern Walk <bwalk@xxxxxxxxxxxxx> > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > > Qualifies as a build-breaker fix, but I'd like a review before pushing. Looks good to me.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
