Re: [PATCH 3/4] qemu: error out on attempt to change blkiotune group name

[Laine Stump <laine@xxxxxxxxx>]

On 3/28/19 10:34 AM, Ján Tomko wrote:
> Check that the attribute is the same in qemuDomainDiskChangeSupported
> in case somebody tries to change it using the UpdateDevice API.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1601677
>
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>   src/qemu/qemu_domain.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 72e322d6a7..e75ea15c91 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -9398,6 +9398,8 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk,
>       CHECK_EQ(blkdeviotune.size_iops_sec,
>                "blkdeviotune size_iops_sec",
>                true);
> +    CHECK_STREQ_NULLABLE(blkdeviotune.group_name,
> +                         "blkdeviotune group name");
>   
>       if (disk->serial && STRNEQ_NULLABLE(disk->serial, orig_disk->serial)) {
>           virReportError(VIR_ERR_OPERATION_UNSUPPORTED,


Again, as long as "no serial specified" is supposed to mean "serial 
remains unchanged" rather than "there should be no serial", then


Reviewed-by: Laine Stump <laine@xxxxxxxxx>



--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list