On Wed, Mar 27, 2019 at 05:07:11AM -0500, Eric Blake wrote: > I've finished rebasing my earlier v4/v5 patches on top of cleanups > earlier in the series (v6 didn't include the second half of the > series). I've pushed a tag backup-v7 to both my libvirt.git and > libvirt-python.git repos to match: > https://repo.or.cz/libvirt/ericb.git/shortlog/refs/tags/backup-v7 > https://repo.or.cz/libvirt-python/ericb.git/shortlog/refs/tags/backup-v7 > > Here's hoping we're happy enough with the API, including the fact that > rudimentary operation of pull mode backups work with qemu 4.0-rc1, for > this to make it into the 5.2 release. I think we need to accept that we've missed the boat for 5.2 now I'm afraid. While I'm fine with the API design, it feels contrary to our norms to only push the API and not the implementation. We've seen some destablization of build from the preparatory patches, so we shouldn't push our luck by adding more at the last minute. Even if it merges, it won't be actually usable so there's no reason to rush this from an upstream POV. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list