Re: [PATCH v7 01/23] snapshot: Drop pointless function virDomainMomentIsCurrentName

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 27, 2019 at 05:07:12AM -0500, Eric Blake wrote:
> The qemu driver already had a full-blown virDomainMomentObjPtr to
> check against, and the test driver ought to have one since we get
> better error checking that the user passed in a valid object. Removes
> a helper function added in commit commit 4819f54b.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/conf/virdomainmomentobjlist.h   | 2 --
>  src/conf/virdomainsnapshotobjlist.h | 2 --
>  src/conf/virdomainmomentobjlist.c   | 9 ---------
>  src/conf/virdomainsnapshotobjlist.c | 9 ---------
>  src/libvirt_private.syms            | 1 -
>  src/qemu/qemu_driver.c              | 2 +-
>  src/test/test_driver.c              | 7 ++++++-
>  7 files changed, 7 insertions(+), 25 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux