Re: [PATCH v6 2/9] Revert "snapshot: Add virDomainSnapshotObjListFormat"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 26, 2019 at 01:13:46AM -0500, Eric Blake wrote:
> This reverts commit 86c0ed6f70268dfa7c3bba95a0ba96fcfe2ab039, and
> subsequent refactorings of the function into new files.  There are no
> callers of this function - I had originally proposed it for
> implementing a new bulk snapshot API, but that proved to be too
> invasive given RPC limits. I also tried using it for streamlining how
> the qemu driver stores snapshot state across libvirtd restarts
> internally, but in the end, the risks of a new internal format
> outweighed the benefits of one file per snapshot.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/conf/snapshot_conf.h            |  7 ----
>  src/conf/virdomainsnapshotobjlist.h |  7 ----
>  src/conf/snapshot_conf.c            |  2 +-
>  src/conf/virdomainsnapshotobjlist.c | 61 -----------------------------
>  src/libvirt_private.syms            |  1 -
>  5 files changed, 1 insertion(+), 77 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux