On Mon, Mar 25, 2019 at 13:24:29 -0400, Laine Stump wrote: > The Chr and Lease devices have detach code that is too different from > the other device types to handle with common functionality (which will > soon be added at the end of qemuDomainDetachDeviceLive(). In order to > make this difference obvious, move the cases for those two device > types to the top of the switch statement in > qemuDomainDetachDeviceLive(), have the cases return immediately so the > future common code at the end of the function will be skipped, and > also include some hopefully helpful comments to remind future > maintainers why these two device types are treated differently. > > Any attempt to detach an unsupported device type should also skip the > future common code at the end of the function, so the case for > unsupported types is similarly changed from a simple break to a return > -1. > > Signed-off-by: Laine Stump <laine@xxxxxxxxx> > --- ACK
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
