On Thu, Mar 21, 2019 at 18:28:56 -0400, Laine Stump wrote: > The individual qemuDomainDetach*Device() functions will soon be "less > functional", since some of the code that is duplicated in 10 of the 12 > detach functions is going to be moved into the common > qemuDomainDetachDeviceLive(), which calls them all. > > qemuhotplugtest.c is the only place any of these individual functions > is called other than qemuDomainDetachDeviceLive() itself. Fortunately, > qemuDomainDetachDeviceLive() provides exactly the functionality needed > by the test driver (except that it supports detach of more device > types than the test driver has tests for). > > This patch replaces the calls to > qemuDomainDetach(Chr|Shmen|Watchdog|Disk)Device with a single call to > the higher level function, allowing us to shift functionality between > the lower level functions without breaking the tests. > > Signed-off-by: Laine Stump <laine@xxxxxxxxx> > --- > src/qemu/qemu_hotplug.c | 15 ++++++++------- > src/qemu/qemu_hotplug.h | 16 ---------------- > tests/qemuhotplugtest.c | 8 +------- > 3 files changed, 9 insertions(+), 30 deletions(-) The change makes sense, but keep the function header changes separate.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
