On 21.03.2019 15:09, Daniel P. Berrangé wrote: > On Thu, Mar 21, 2019 at 10:32:07AM +0300, Nikolay Shirokovskiy wrote: >> Commit d1a7c08eb changed filter instantiation code to ignore MAC and IP >> variables explicitly specified for filter binding. It just replaces >> explicit values with values associated with the binding. Before the >> commit virNWFilterCreateVarsFrom was used so that explicit value >> take precedence. Let's bring old behavior back. >> >> This is useful. For example if domain has two interfaces it makes >> sense to list both mac adresses in MAC var of every interface >> filterref. So that if guest make a bond of these interfaces >> and start sending frames with one of the mac adresses from >> both interfaces we can pass outgress traffic from both >> interfaces too. >> >> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx> >> --- >> src/nwfilter/nwfilter_gentech_driver.c | 92 ++++++++++++---------------------- >> 1 file changed, 32 insertions(+), 60 deletions(-) > > Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > Pushed. Thanx! Nikolay -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
