On Thu, Mar 21, 2019 at 18:28:43 -0400, Laine Stump wrote: > When support for hotplug/unplug of SCSI controllers was added way back > in December 2009 (commit da9d937b), unplug was handled by calling the > now-extinct function qemuMonitorRemovePCIDevice(), which required a > PCI address as an argument. At the same time, the idea of every device > in the config having a PCI address apparentlty was not yet fully > implemented, because the author of the patch including a check for a > valid PCI address in the device object. > > These days, all PCI devices are guaranteed to have a valid PCI > address. But more important than that, we no longer detach devices by > PCI address, but instead use qemuDomainDeleteDevice(), which > identifies the device by its alias. So checking for a valid PCI > address is just pointless extra code that obscures the high level of > similarity between all the individual qemuDomainDetach*Device() > functions. > > Signed-off-by: Laine Stump <laine@xxxxxxxxx> > --- > src/qemu/qemu_hotplug.c | 16 ---------------- > 1 file changed, 16 deletions(-) ACK
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
