On 3/21/19 7:33 PM, John Ferlan wrote: > > > On 3/20/19 1:41 AM, Eric Blake wrote: >> Finish the code motion of generic moment list handling. Well, mostly - >> we need to convert to using virObject to get polymorphic cleanup >> functions (so for now there are still a few lingering ties specific to >> snapshots). In this case, I kept virDomainSnapshotObjList as a >> wrapper type around the new generic virDomainMomentObjList; the bulk >> of the algorithms move, but the old functions remain and forward to >> the generic helpers. >> >> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> >> --- >> src/conf/virconftypes.h | 3 + >> src/conf/virdomainmomentobjlist.h | 32 +++ >> src/conf/virdomainsnapshotobjlist.h | 6 - >> src/conf/virdomainmomentobjlist.c | 356 ++++++++++++++++++++++++++++ >> src/conf/virdomainsnapshotobjlist.c | 266 +++------------------ >> 5 files changed, 422 insertions(+), 241 deletions(-) I decided to split this (I was having a hard time reviewing my own code); the split is pretty straightforward: the new code in virdomainmomentobjlist.c (which can then be easily compared to the existing virdomainsnapshotobjlist.c code for that patch), then the rework of virdomainsnapshotobjlist.c to wrap the new type. But since the end result after the split is the same as what you reviewed... > > I'll go with this even though it's not perfect - to some degree it may > only be a name change or just technical debt promise of a future patch > and of course review to do something. > > I'm not worried yet so much about the *AssignDef note, but it is > something you may want to consider. > > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> > ...I went ahead and kept your R-b on both halves of my split. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
