Re: [PATCH v3 03/36] conf: simplify link from hostdev back to network device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
> hostdevs have a link back to the original network device. This is fairly
> generic accepting any type of device, however, we don't intend to make
> use of this approach in future. It can thus be specialized to network
> devices.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c         | 18 ++++++++----------
>  src/conf/domain_conf.h         |  8 +++++++-
>  src/libxl/libxl_driver.c       |  4 ++--
>  src/network/bridge_driver.c    |  3 +--
>  src/qemu/qemu_command.c        |  3 +--
>  src/qemu/qemu_domain_address.c |  4 ++--
>  src/qemu/qemu_driver.c         |  2 +-
>  src/qemu/qemu_hotplug.c        | 14 ++++++--------
>  src/qemu/qemu_hotplug.h        |  2 +-
>  src/util/virhostdev.c          | 17 ++++++++---------
>  10 files changed, 37 insertions(+), 38 deletions(-)
> 

If it doesn't cause too many conflicts I'd say rename it to parentnet
while you're at it. If not it could be a follow up change, parent is
just too generic sounding in this case

Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx>

And it could go in now IMO

- Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux