On 3/20/19 6:47 AM, Ján Tomko wrote: > On Wed, Mar 20, 2019 at 12:40:50AM -0500, Eric Blake wrote: >> The following virsh command was triggering a use-after-free: >> >> $ virsh -c test:///default ' >> snapshot-create-as test s1 >> snapshot-create-as test s2 >> snapshot-delete --children-only test s1 >> snapshot-current --name test' >> Domain snapshot s1 created >> Domain snapshot s2 created >> Domain snapshot s1 children deleted >> >> >> Ideally, I'd get rid of the 'current' member in virDomainSnapshotDef, >> as well as the 'current_snapshot' member in virDomainDef, and instead >> track the current member in virDomainSnapshotObjList, coupled with >> writing ALL snapshot state for qemu in a single file (where I can use >> <snapshots current='...'> as a wrapper, rather than >> VIR_DOMAIN_SNAPSHOT_FORMAT_INTERNAL to output <current>1</current> XML >> on a per-snapshot file basis). But that's a bigger change, so for now >> I'm just patching things to avoid the test driver segfault. For the record, the rest of this series (including the just-posted 17 and 18/16) proceed to do all of this additional work. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
