On Mon, 2019-03-18 at 15:46 -0400, Cole Robinson wrote:
> These blocks are only triggered when updating from a libvirt version
> less than 0.9.4, which was released in august 2011. I think it's been
s/august/August/
> long enough that we can say this upgrade path is unsupported without
> an intermediate step
Missing period at the end of the sentence.
[...]
> +++ b/libvirt.spec.in
> @@ -1444,16 +1444,6 @@ fi
> rm -rf %{_localstatedir}/lib/rpm-state/libvirt || :
>
>
You can drop an extra empty line here.
I believe these changes are safe, so
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
Please leave the patch on the list a few days before pushing,
though, in order to give other developers a fair opportunity to
raise any concerns they might have.
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
