On Sun, Mar 17, 2019 at 06:04:27 +0000, Humaid wrote: > From: Ubuntu <shbh@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> This address is not resolvable your git is probably misconfigured. Please provide a commit message according to the contributor guildelines including certification of agreement with the developer certificate of origin. https://libvirt.org/hacking.html#patches > > --- > src/qemu/qemu_tpm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c > index 835a9caf46..b60e443f14 100644 > --- a/src/qemu/qemu_tpm.c > +++ b/src/qemu/qemu_tpm.c > @@ -834,16 +834,16 @@ qemuExtTPMStartEmulator(virQEMUDriverPtr driver, > > > int > -qemuExtTPMStart(virQEMUDriverPtr driver, > - virDomainObjPtr vm, > +qemuExtTPMStart(virDomainObjPtr vm, > qemuDomainLogContextPtr logCtxt) This does not fix any of the callers nor the header file thus breaks the build. Additionally without any further refactors and no justification in the commit message I don't see much value in this change. Please write a commit message and justify it.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
