Re: [PATCH v6 5/8] snapshot: Break out virDomainSnapshotObjList into its own file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/15/19 12:02 AM, Eric Blake wrote:
> snapshot_conf.h was mixing three separate types: the snapshot
> definition, the snapshot object, and the snapshot object list.
> Separate out the snapshot object list code into its own file, and
> update includes for affected clients.
> 
> This is just code motion, but done in preparation of sharing a lot of
> the object list code with checkpoints.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---

> +++ b/src/conf/virdomainsnapshotobjlist.h
> @@ -0,0 +1,74 @@

> +#ifndef LIBVIRT_VIRDOMAINSNAPSHOTOBJLIST_H
> +# define LIBVIRT_VIRDOMAINSNAPSHOTOBJLIST_H
> +
> +# include "internal.h"
> +# include "virdomainsnapshotobj.h"
> +# include "capabilities.h"

This one felt a bit unclean. I'll submit a patch 1.5/8 that moves the
typedefs from capabilities.h int virconftypes.h, then fix 2/8 to sort
those into place as well.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux