On Fri, Mar 15, 2019 at 12:02:28AM -0500, Eric Blake wrote:
snapshot_conf.h was mixing three separate types: the snapshot definition, the snapshot object, and the snapshot object list. Separate out the snapshot object code into its own file, which includes moving a typedef to avoid circular inclusions. Mostly straight code motion, although I fixed a comment along the way.
Technically comments aren't code.
Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> --- src/conf/snapshot_conf.h | 20 +----- src/conf/virconftypes.h | 3 + src/conf/virdomainsnapshotobj.h | 50 +++++++++++++ src/conf/Makefile.inc.am | 2 + src/conf/snapshot_conf.c | 85 ---------------------- src/conf/virdomainsnapshotobj.c | 122 ++++++++++++++++++++++++++++++++ src/libvirt_private.syms | 9 ++- 7 files changed, 184 insertions(+), 107 deletions(-) create mode 100644 src/conf/virdomainsnapshotobj.h create mode 100644 src/conf/virdomainsnapshotobj.c diff --git a/src/conf/snapshot_conf.h b/src/conf/snapshot_conf.h index 6d79dbb0da..444de05a71 100644 --- a/src/conf/snapshot_conf.h +++ b/src/conf/snapshot_conf.h @@ -24,6 +24,7 @@ # include "internal.h" # include "domain_conf.h" +# include "virdomainsnapshotobj.h"
Oh, I found the other files using the 'vir' prefix and the no spacing approach.
/* Items related to snapshot state */
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
