Re: [PATCH v2 2/3] xml: nodedev: add class info for pci capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 12, 2019 at 02:14:40PM +0300, Nikolay Shirokovskiy wrote:
> This info can be useful to filter devices visible
> to mgmt clients so that they won't see devices that
> unsafe/not meaningful to pass thru.
> 
> Provide class info the way it is provided by udev or
> kernel that is as single 6-digit hexadecimal.
> 
> Class element is not optional. I guess this should not
> break users that use virNodeDeviceCreateXML because
> they probably specify only scsi_host capability on
> input and then node device driver gets other capabilities
> from udev after device appeared.
> 
> HAL driver does not get support for the new element in
> this patch.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>
> ---
>  docs/formatnode.html.in                                     |  5 +++++
>  docs/schemas/nodedev.rng                                    |  5 +++++
>  src/conf/node_device_conf.c                                 | 13 +++++++++++++
>  tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml    |  1 +
>  tests/nodedevschemadata/pci_0000_00_1c_0_header_type.xml    |  1 +
>  tests/nodedevschemadata/pci_0000_02_10_7_mdev_types.xml     |  1 +
>  tests/nodedevschemadata/pci_0000_02_10_7_sriov.xml          |  1 +
>  .../nodedevschemadata/pci_0000_02_10_7_sriov_pf_vfs_all.xml |  1 +
>  .../pci_0000_02_10_7_sriov_pf_vfs_all_header_type.xml       |  1 +
>  tests/nodedevschemadata/pci_0000_02_10_7_sriov_vfs.xml      |  1 +
>  .../pci_0000_02_10_7_sriov_zero_vfs_max_count.xml           |  1 +
>  tests/nodedevschemadata/pci_1002_71c4.xml                   |  1 +
>  tests/nodedevschemadata/pci_8086_0c0c_snd_hda_intel.xml     |  1 +
>  tests/nodedevschemadata/pci_8086_10c9_sriov_pf.xml          |  1 +
>  tests/nodedevschemadata/pci_8086_4238_pcie_wireless.xml     |  1 +
>  tests/nodedevschemadata/pci_82579LM_network_adapter.xml     |  1 +
>  16 files changed, 36 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux