[PATCH 1/2] qemuFirmwareFetchConfigs: Fix check for @privileged

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

The qemuFirmwareFetchConfigs() function is supposed to fetch all
firmware descriptions from paths defined by firmware.json
specification. This includes user's $HOME directory. However, it
was agreed that if libvirtd is running as privileged user then
his $HOME is ignored (thus $HOME is included in the search only
for regular users). Well, I got the condition wrong - it should
have been reversed.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
 src/qemu/qemu_firmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
index b423ab10e4..4ce010caaa 100644
--- a/src/qemu/qemu_firmware.c
+++ b/src/qemu/qemu_firmware.c
@@ -974,7 +974,7 @@ qemuFirmwareFetchConfigs(char ***firmwares,
 
     *firmwares = NULL;
 
-    if (privileged) {
+    if (!privileged) {
         /* This is a slight divergence from the specification.
          * Since the system daemon runs as root, it doesn't make
          * much sense to parse files in root's home directory. It
-- 
2.19.2

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list