Jonh, I split the 1st patch the other way to avoid changing same lines of code in subsequent patches. Diff to v1[1] - split 1st patch into 3 - change wordings of commit messages/error messages - add minor changes to code as suggested by John [1] https://www.redhat.com/archives/libvir-list/2019-February/msg00920.html Nikolay Shirokovskiy (4): tools: console: cleanup console on errors in main thread tools: console: add missing locks in callbacks tools: console: check if console was shutdown in callbacks tools: console: pass stream/fd errors to user tools/virsh-console.c | 224 ++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 171 insertions(+), 53 deletions(-) -- 1.8.3.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list