On Thu, Mar 07, 2019 at 10:29:15AM +0100, Michal Privoznik wrote: > This is going to extend virDomainLoader enum. The reason is that > once loader path is NULL its type makes no sense. However, since > value of zero corresponds to VIR_DOMAIN_LOADER_TYPE_ROM the > following XML would be produced: > > <os> > <loader type='rom'/> > ... > </os> > > To solve this, introduce VIR_DOMAIN_LOADER_TYPE_NONE which would > correspond to value of zero and then use post parse callback to > set the default loader type to 'rom' if needed. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > Reviewed-by: Laszlo Ersek <lersek@xxxxxxxxxx> > --- > src/conf/domain_conf.c | 23 +++++++++++++++++++++-- > src/conf/domain_conf.h | 3 ++- > src/qemu/qemu_command.c | 1 + > src/qemu/qemu_domain.c | 1 + > tests/domaincapsschemadata/full.xml | 1 + > 5 files changed, 26 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
