On 3/7/19 1:14 PM, Eric Blake wrote:
> On 3/7/19 8:01 AM, John Ferlan wrote:
>
>>> Upcoming patches will add new flags for increasing the amount of
>>> information present in <domain> dumpxml, but where the source
>>> of that information is tied to somewhere other than the active
>>> or offline domain sub-definition. Make those extensions easier
>>> by updating internal callers to pass in a struct, rather than
>>> adding new parameters for each extension, so that later patches
>>> only have to patch callers that care about a new member of the
>>> struct rather than all callers.
>>>
>
>>
>> The structure formatting of _virDomainDefFormatData and friends is a bit
>> non-standard from what is typically done, but not incorrect.
>
> Do you have a pointer to a struct I should be copying from? I don't mind
> making that sort of cosmetic cleanup for code-base consistency.
>
Usually it's like...
typedef struct _virDomainDef virDomainDef;
typedef virDomainDef *virDomainDefPtr;
struct _virDomainDef {
...
};
John
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
