On Wed, Mar 06, 2019 at 17:54:01 +0100, Andrea Bolognani wrote: > Despite its name, this is really just a general-purpose string > manipulation function, so it should be moved to the virstring > module and renamed accordingly. > > A few trivial whitespace changes are squashed in. > > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > src/conf/virdomainobjlist.c | 2 +- > src/conf/virnetworkobj.c | 4 ++-- > src/conf/virnwfilterbindingobjlist.c | 2 +- > src/conf/virnwfilterobj.c | 2 +- > src/conf/virstorageobj.c | 2 +- > src/libvirt_private.syms | 2 +- > src/util/virfile.c | 18 ------------------ > src/util/virfile.h | 3 --- > src/util/virstring.c | 18 ++++++++++++++++++ > src/util/virstring.h | 2 ++ > tests/testutilsqemu.c | 2 +- > 11 files changed, 28 insertions(+), 29 deletions(-) ACK. You could also fix the return value type.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
