[PATCH v2 3/8] iscsi_direct: Don't overwrite error in virStorageBackenISCSIDirectWipeVol()

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

If virStorageBackendISCSIDirectVolWipeZero() fails, it has
already reported an error which is probably specific enough. Do
not overwrite it with some generic one.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
 src/storage/storage_backend_iscsi_direct.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/storage/storage_backend_iscsi_direct.c b/src/storage/storage_backend_iscsi_direct.c
index 0af7adf32c..613c38e225 100644
--- a/src/storage/storage_backend_iscsi_direct.c
+++ b/src/storage/storage_backend_iscsi_direct.c
@@ -706,12 +706,8 @@ virStorageBackenISCSIDirectWipeVol(virStoragePoolObjPtr pool,
 
     switch ((virStorageVolWipeAlgorithm) algorithm) {
     case VIR_STORAGE_VOL_WIPE_ALG_ZERO:
-        if (virStorageBackendISCSIDirectVolWipeZero(vol, iscsi) < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("failed to wipe volume %s"),
-                           vol->name);
+        if (virStorageBackendISCSIDirectVolWipeZero(vol, iscsi) < 0)
             goto cleanup;
-        }
         break;
     case VIR_STORAGE_VOL_WIPE_ALG_TRIM:
     case VIR_STORAGE_VOL_WIPE_ALG_NNSA:
-- 
2.19.2

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list