Re: [PATCH 4/4] Revert "Separate out StateAutoStart from StateInitialize"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 04, 2019 at 03:02:13PM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1685151

This reverts commit e4a969092bda5b3b952963fdf6658895165040b7.

Now that drivers may call virConnectOpen() on secondary drivers,
it doesn't make much sense to have autostart separated from
driver initialization callback. In fact, it creates a problem
because one driver during its initialization might try to fetch
an object from another driver but since the object is yet to be
autostarted the fetch fails. This has been observed in reality:
qemu driver performs qemuProcessReconnect() during qemu's
stateInitialize phase which may call
virDomainDiskTranslateSourcePool() which connects to the storage
driver to look up the volume. But the storage driver did not
autostarted its pools yet therefore volume lookup fails and

s/autostarted/autostart/

the domain is killed.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
src/driver-state.h |  4 ----
src/libvirt.c      | 14 +-------------
2 files changed, 1 insertion(+), 17 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux