On Mon, Mar 04, 2019 at 04:00:01PM -0700, Jim Fehlig wrote: > Xen 4.10 introduced the max_grant_frames xl config setting, which > can be set globally in xl.conf(5) or per-domain in xl.cfg(5). > max_grant_frames specifies the maximum number of grant frames the > domain is allowed to have, which in turn controls the number of > pages the domain can share. Does the grant frame value have any impact on the live migration compatibility ? ie if both source and dest host are required to have identical grant frame values, then it is preferrable to /not/ have this as a host tunable, but only as XML. You generally don't want anything affecting mig compatibility in host level configs. > > This patch adds support for setting max_grant_frames on a global > level in libxl.conf. Per-domain support via domXML can be provided > in a future patch. > > Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> > --- > src/libxl/libvirtd_libxl.aug | 2 ++ > src/libxl/libxl.conf | 8 ++++++++ > src/libxl/libxl_conf.c | 9 +++++++++ > src/libxl/libxl_conf.h | 2 ++ > src/libxl/test_libvirtd_libxl.aug.in | 1 + > 5 files changed, 22 insertions(+) If-only-if this is ok for live migration compat, then Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
