On Mon, Mar 04, 2019 at 11:49:54AM -0300, Daniel Henrique Barboza wrote: > > > On 3/4/19 10:10 AM, Erik Skultety wrote: > > On Sun, Mar 03, 2019 at 10:23:12AM -0300, Daniel Henrique Barboza wrote: > > > passthroughLimit is being calculated even if usesVFIO is false. > > > After that, a if/else conditional is used to check if we're going > > > to sum it up with baseLimit. > > > > > > This patch initializes passthroughLimit to zero and always > > > return memKB = baseLimit + passthroughLimit. The conditional > > > is then used to calculate passthroughLimit if usesVFIO is true. > > > This results in some cycles spared for the usesVFIO=false > > > scenario, but the real motivation is to make the code simpler > > > to add an alternative passthroughLimit formula for NVLink2 > > > passthrough. > > > > > > Signed-off-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx> > > > --- > > ACK to the idea, but looking at the number of lines of the PPC64 arch specific > > logic (I know commentaries mostly), I think it deserves a separate helper to > > enhance the readability. > > You mean a 'static unsigned long long getPPC64MemLockLimit' like function > that > encapsulates the ppc64 logic? That can be arranged, no problem. Yep, exactly. Erik -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
