Re: [PATCH v2] storage: Fix iscsi-direct volume size for volumes > 4GiB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/28/19 4:10 PM, Jiri Denemark wrote:
Both block_size and nb_block are unit32_t and multiplying them overflows
at 4GiB.

Moreover, the iscsi_*10_* APIs use 32bit number of blocks and thus they
can only address images up to 2TiB with 512B blocks. Let's use 64b
iscsi_*16_* APIs instead.

Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
---

Notes:
     Version 2:
     - also fix volumes > 2TiB

  src/storage/storage_backend_iscsi_direct.c | 22 +++++++++++-----------
  1 file changed, 11 insertions(+), 11 deletions(-)

ACK and safe for the freeze.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux