Re: [PATCH v1 10/15] qemufirmwaretest: Test qemuFirmwareFetchConfigs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/27/19 11:04, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  tests/Makefile.am                             |  1 +
>  .../etc/qemu/firmware/40-ovmf-sb.json         |  1 +
>  .../etc/qemu/firmware/60-ovmf.json            |  0
>  .../user/.config/qemu/firmware/10-bios.json   |  0
>  .../share/qemu/firmware}/40-bios.json         |  0
>  .../share/qemu/firmware}/50-ovmf-sb.json      |  0
>  .../share/qemu/firmware}/60-ovmf.json         |  0
>  .../share/qemu/firmware}/70-aavmf.json        |  0
>  tests/qemufirmwaretest.c                      | 69 +++++++++++++++++--
>  9 files changed, 66 insertions(+), 5 deletions(-)
>  create mode 120000 tests/qemufirmwaredata/etc/qemu/firmware/40-ovmf-sb.json
>  create mode 100644 tests/qemufirmwaredata/etc/qemu/firmware/60-ovmf.json
>  create mode 100644 tests/qemufirmwaredata/home/user/.config/qemu/firmware/10-bios.json
>  rename tests/qemufirmwaredata/{ => usr/share/qemu/firmware}/40-bios.json (100%)
>  rename tests/qemufirmwaredata/{ => usr/share/qemu/firmware}/50-ovmf-sb.json (100%)
>  rename tests/qemufirmwaredata/{ => usr/share/qemu/firmware}/60-ovmf.json (100%)
>  rename tests/qemufirmwaredata/{ => usr/share/qemu/firmware}/70-aavmf.json (100%)

Right, so I think it makes sense to introduce the double-digit priority
prefixes first in this patch, as part of the rename. They matter here,
but they don't matter in the previous test case.

No other comments for now regarding this patch; I hope that's not a problem.

Thanks
Laszlo

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux